-
-
Notifications
You must be signed in to change notification settings - Fork 345
ci: added treefmt workflow to gha and removed from buildbot #3611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
a6bfab9
to
bf6ca2f
Compare
Hi @MattSturgeon is there anything else that you need on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is complicated a little by merge queues and "required status checks", however I'm fine merging this initially without adding it as a "required" check.
#3628 can then be responsible for implementing the required checks for PRs and merge queues.
A few minor things to address or discuss below, then I think we can get this merged.
Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Seemed like low hanging fruit in #3561